[BUG] Add `.docker.internal` entries to `cmd/crc/cmd/daemon.go` ?

crc-org / crc

CRC is a tool to help you run containers. It manages a local OpenShift 4.x cluster, Microshift or a Podman VM optimized for testing and development purposes

https://crc.dev

Apache License 2.0

1.23k stars 231 forks source link

[BUG] Add `.docker.internal` entries to `cmd/crc/cmd/daemon.go` ? #3784

Open cfergeau opened 11 months ago

cfergeau commented 11 months ago

This would match what is being done in https://github.com/containers/gvisor-tap-vsock/pull/251

praveenkumar commented 11 months ago

As of now for crc we only offer host.crc.testing in case user want to access services from host and for that he need to enable the host-network-access setting. We added gateway.containers.internal to our daemon code because that was need to run the container using podman to expose the port on the host.

Now if we really want to have same compatibility as podman-machine have then we need to add entry for host.containers.internal and also gateway/host.docker.internal.