[QE] Wrong base images for e2e and integration container images

[adrianriobo]

The builder image used on the e2e and integration Dockerfiles does not exists, as so when trying to build them we got an error like:

CRC_E2E_IMG_VERSION=v2.29.0-dev make containerized_e2e
rm -rf /home/ariobolo/01WORKSPACE/04SOURCE/github/crc/docs/build
rm -f packaging/darwin/Distribution
rm -f packaging/darwin/Resources/welcome.html
rm -f packaging/darwin/scripts/postinstall
rm -rf packaging/darwin/root-crc/
rm -rf packaging/darwin/root-crc-tray/
rm -rf packaging/windows/msi
rm -f out/linux-amd64/split
rm -f packaging/rpm/crc.spec images/rpmbuild/Containerfile
rm -rf out
rm -f /home/ariobolo/go/bin/crc
rm -rf release
podman build -t quay.io/crcont/crc-e2e:v2.29.0-dev -f images/build-e2e/Dockerfile .
[1/2] STEP 1/5: FROM registry.access.redhat.com/ubi8/go-toolset:1.20 AS builder
Trying to pull registry.access.redhat.com/ubi8/go-toolset:1.20...
Error: error creating build container: initializing source docker://registry.access.redhat.com/ubi8/go-toolset:1.20: reading manifest 1.20 in registry.access.redhat.com/ubi8/go-toolset: manifest unknown: manifest unknown
make: *** [Makefile:199: containerized_e2e] Error 125

[cfergeau]

I tried adding a make container-images target to the Makefile which could be part of make check. This works, but is very slow, so I'm not sure it's desirable as part of make check which already takes quite some time :-/

[adrianriobo]

Yeah another option would be have an specific check goal for building the images and then only run it as a checker if PRs has some specific labeling (like oci-images), that label will be added just in case the PR change something on them .

But maybe it is not worthwhile to add all this just for those images, as I am checking them multiple times along the sprint

[adrianriobo]

Fixed by https://github.com/crc-org/crc/commit/1f072afd072774d921f8b9b8728dbef5b4b6f6fc