search

crc-org / crc

CRC is a tool to help you run containers. It manages a local OpenShift 4.x cluster, Microshift or a Podman VM optimized for testing and development purposes
https://crc.dev
Apache License 2.0
1.27k stars 242 forks source link

Revert winio and take some commits from pr-4139 #4151

Closed praveenkumar closed 6 months ago

praveenkumar commented 6 months ago

I would keep the last 3 commits for the "update go to 1.21" PR, I don't think they are needed in this PR?

@cfergeau they make sure that go mod tidy run on specific version of golang so once this is merged I can rebase all the dependent bot PR's to see if something fails. and those commits have nothing to do with 1.21 but what golang version we use.

openshift-ci[bot] commented 6 months ago

@praveenkumar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 8b98606832c17ee759a90fd5f9fd3e025c8e8af1 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/crc-org/crc/blob/main/OWNERS)~~ [cfergeau] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
gbraad commented 5 months ago

Why is this revert necessary?

cfergeau commented 5 months ago

Why is this revert necessary?

It's in the commit log:

This reverts commit https://github.com/crc-org/crc/commit/ec6cbfb3d35f433a6285bda4b12badb45e97f915. Because it uses go-1.21 and we are still using go-1.20

But we've switched to golang 1.21 since then, and winio is again 0.6.2