search

crc-org / crc

CRC is a tool to help you run containers. It manages a local OpenShift 4.x cluster, Microshift or a Podman VM optimized for testing and development purposes
https://crc.dev
Apache License 2.0
1.26k stars 242 forks source link

fix 'sed -i' failure in Makefile for macOS #4226

Closed lilyLuLiu closed 5 months ago

lilyLuLiu commented 5 months ago

make release fail with error message:

cat: release-info.json: No such file or directory

The file release-info.json was moved to folder release. Thus check-release-info can't find the file

sed -i failed in Makefile when running in MacOS

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign adrianriobo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/crc-org/crc/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
cfergeau commented 5 months ago

Can we keep this 2 separate commits? (the sed changes and the cp->mv change) Both will be needed, but they fix 2 very different things, so better to keep them separate.

I've filed https://github.com/crc-org/crc/pull/4227 which fixes more issues with the release-info check, but which will need the fixes from this PR.

praveenkumar commented 5 months ago

@lilyLuLiu can you drop https://github.com/crc-org/crc/pull/4226/commits/c97baee07a5af1b642c2bf1bd62aee5340b54e07 one and have only one commit because other part is fix in #4227

lilyLuLiu commented 5 months ago

@praveenkumar , Hi, I separated the commit as @cfergeau suggested.

openshift-ci[bot] commented 5 months ago

@lilyLuLiu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-microshift-crc 424f9ffdb1cfbe221a67af6d253964325311998a link true /test e2e-microshift-crc
ci/prow/e2e-crc 424f9ffdb1cfbe221a67af6d253964325311998a link true /test e2e-crc
ci/prow/integration-crc 424f9ffdb1cfbe221a67af6d253964325311998a link true /test integration-crc
ci/prow/security 66b3e5d2b8a74702bdc00349e64cabeb7850f611 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
praveenkumar commented 5 months ago

/close

changes merged with #4227