search

crc-org / crc

CRC is a tool to help you run containers. It manages a local OpenShift 4.x cluster, Microshift or a Podman VM optimized for testing and development purposes
https://crc.dev
Apache License 2.0
1.26k stars 242 forks source link

Add `nvram` option for undefine vm #4229

Closed praveenkumar closed 5 months ago

praveenkumar commented 5 months ago

With https://github.com/crc-org/machine-driver-libvirt/commit/a130898ad92b7e4a9d5cefb853dd63a0480e38e3 now nvram is added to domain template and as part of undefine it we need to use this flag otherwise following error occur during crc cleanup if domain is present.

Code=55, Domain=10, Message='Requested operation is not valid: cannot undefine domain with nvram'

This pr even work with current template where no <nvram /> present.

Fixes: Issue #4228

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/crc-org/crc/blob/main/OWNERS)~~ [cfergeau] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 5 months ago

@praveenkumar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 02302cee025c5c18ef8ba0c074b561b7b4969c1b link false /test security
ci/prow/e2e-microshift-crc 02302cee025c5c18ef8ba0c074b561b7b4969c1b link true /test e2e-microshift-crc
ci/prow/integration-crc 02302cee025c5c18ef8ba0c074b561b7b4969c1b link true /test integration-crc
ci/prow/e2e-crc 02302cee025c5c18ef8ba0c074b561b7b4969c1b link true /test e2e-crc
ci/prow/images 02302cee025c5c18ef8ba0c074b561b7b4969c1b link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).