search

crc-org / crc

CRC is a tool to help you run containers. It manages a local OpenShift 4.x cluster, Microshift or a Podman VM optimized for testing and development purposes
https://crc.dev
Apache License 2.0
1.26k stars 242 forks source link

build: Update k8s and openshift go modules to sync with openshift-4.16 #4253

Closed praveenkumar closed 4 months ago

praveenkumar commented 4 months ago

This updates the github.com/openshift/* modules to release-4.16 and k8s.io/* to v0.29.3.

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from praveenkumar. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/crc-org/crc/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
praveenkumar commented 4 months ago

o it's a bit early for this change. This could go in the same PR as the one switching the Makefile to 4.16.

Yes, we can put it on hold till then, I don't think it break current master because from bundle side it is not going to break (no specific code at bundle side).

praveenkumar commented 4 months ago

/hold

praveenkumar commented 4 months ago

/unhold

Updated the bundle to 4.16 also.

openshift-ci[bot] commented 4 months ago

@praveenkumar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 486ce3c70c0c8bd52070e0f3c5ad87e171177b56 link false /test security
ci/prow/integration-crc 486ce3c70c0c8bd52070e0f3c5ad87e171177b56 link true /test integration-crc
ci/prow/e2e-crc 486ce3c70c0c8bd52070e0f3c5ad87e171177b56 link true /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).