search

crc-org / crc

CRC is a tool to help you run containers. It manages a local OpenShift 4.x cluster, Microshift or a Podman VM optimized for testing and development purposes
https://crc.dev
Apache License 2.0
1.26k stars 242 forks source link

Spec: Append arch info for admin-helper and libvirt driver #4254

Closed praveenkumar closed 4 months ago

praveenkumar commented 4 months ago

After 589e1520c531c4fae95e5d6ae39f8a357d22d866 and 926c78e6bfc64ce6a5ed1771d58d637ce34aafe5, the filename detected by embedded binary also have arch info since it takes basename of url for admin-helper and libvirt and both url now have arch info. This PR copy the binary with arch info suffix to fix the following error during rpm build.

 > [6/6] RUN yum config-manager --set-enabled crb &&     yum -y builddep packaging/rpm/crc.spec &&     rpmbuild -bb -v packaging/rpm/crc.spec:
238.6 go build --tags="build" -ldflags="-X github.com/crc-org/crc/v2/pkg/crc/version.crcVersion=2.38.0 -X github.com/crc-org/crc/v2/pkg/crc/version.ocpVersion=4.15.17 -X github.com/crc-org/crc/v2/pkg/crc/version.okdVersion=4.15.0-0.okd-2024-02-23-163410 -X github.com/crc-org/crc/v2/pkg/crc/version.microshiftVersion=4.15.17 -X github.com/crc-org/crc/v2/pkg/crc/version.commitSha=4225c2 -B 0xc4fae8225411a1c1f9d2fbff31dff48012b372b9" -o out/linux-amd64/crc-embedder  ./cmd/crc-embedder
239.8 out/linux-amd64/crc-embedder embed --log-level debug --cache-dir=embed-files/ --no-download --goos=linux out/linux-amd64/crc
239.8 level=debug msg="Embedding embed-files/crc-driver-libvirt-amd64 in out/linux-amd64/crc"
239.8 level=fatal msg="Failed to embed data files: Failed to open embed-files/crc-driver-libvirt-amd64: open embed-files/crc-driver-libvirt-amd64: no such file or directory"
239.8 make: *** [Makefile:326: embed_crc_helpers] Error 1
239.8 error: Bad exit status from /var/tmp/rpm-tmp.Cd7dtB (%build)
openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/crc-org/crc/blob/main/OWNERS)~~ [cfergeau] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 4 months ago

@praveenkumar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 2dbf3274ac34cb1a1bd7f45db91a4962ce2796e0 link false /test security
ci/prow/integration-crc 2dbf3274ac34cb1a1bd7f45db91a4962ce2796e0 link true /test integration-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).