search

crc-org / crc

CRC is a tool to help you run containers. It manages a local OpenShift 4.x cluster, Microshift or a Podman VM optimized for testing and development purposes
https://crc.dev
Apache License 2.0
1.26k stars 242 forks source link

build: Fix binaries not being rebuilt even when there are source changes #4290

Closed cfergeau closed 3 months ago

cfergeau commented 3 months ago

The Makefile has a SOURCES variable which contains a list of all go source files used by crc. It's used as a dependency for the targets building binaries so that the binaries are rebuilt on any source changes.

This broke in 1d104598 when a release_info_test.go file was added to the top level directory. Since SOURCES is set to git ls-files *.go ":^vendor" shell expansion will happen before git ls-files runs, so we'll be running git ls-files release_info_test.go ":^vendor", the SOURCES variable will only contain release_info_test.go instead of the list of all source files, and binaries won't get rebuilt when one of the go files change.

This commit adds quoting around *.go so that this works properly.

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anjannath

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/crc-org/crc/blob/main/OWNERS)~~ [anjannath] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 3 months ago

@cfergeau: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 7bb9172a041395b108290cc1dceaf63d27ff395c link false /test security
ci/prow/integration-crc 7bb9172a041395b108290cc1dceaf63d27ff395c link true /test integration-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).