search

crc-org / crc

CRC is a tool to help you run containers. It manages a local OpenShift 4.x cluster, Microshift or a Podman VM optimized for testing and development purposes
https://crc.dev
Apache License 2.0
1.26k stars 242 forks source link

vfkit: Switch to EFIBootLoader from LinuxBootLoader (BIOS) #4309

Closed praveenkumar closed 3 months ago

praveenkumar commented 3 months ago

vfkit have a way to load efi bootloader and since we are now supporting only macos>13, better to switch it and it also allow a bit code clean around kernel update when start from stopped state.

Fixes: Issue #4308

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from praveenkumar. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/crc-org/crc/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 3 months ago

@praveenkumar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-microshift-crc 4fd662ae4e822a5ffb63f8b97ca89e6bcd212890 link true /test e2e-microshift-crc
ci/prow/images 4fd662ae4e822a5ffb63f8b97ca89e6bcd212890 link true /test images
ci/prow/e2e-crc 4fd662ae4e822a5ffb63f8b97ca89e6bcd212890 link true /test e2e-crc
ci/prow/integration-crc 4fd662ae4e822a5ffb63f8b97ca89e6bcd212890 link true /test integration-crc
ci/prow/security 4fd662ae4e822a5ffb63f8b97ca89e6bcd212890 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
vyasgun commented 3 months ago

Tested this and it is working. The corresponding vfkit command: /Users/podmanqe/.crc/bin/vfkit --cpus 2 --memory 4096 --bootloader efi,variable-store=/Users/podmanqe/.crc/machines/crc/efistore.nvram,create --device virtio-serial,logFilePath=/Users/podmanqe/.crc/machines/crc/vfkit.log --device virtio-fs,sharedDir=/Users/podmanqe,mountTag=dir0 --device virtio-rng --device virtio-blk,path=/Users/podmanqe/.crc/machines/crc/crc.img --device virtio-vsock,port=1024,socketURL=/Users/podmanqe/.crc/tap.sock,listen --timesync vsockPort=1234