search

crc-org / crc

CRC is a tool to help you run containers. It manages a local OpenShift 4.x cluster, Microshift or a Podman VM optimized for testing and development purposes
https://crc.dev
Apache License 2.0
1.26k stars 242 forks source link

test: fix ssh key path in podman integration test #4328

Closed anjannath closed 3 months ago

anjannath commented 3 months ago

in 7bb32ee1e the ssh key algorithm was changed to ed25519 so the resulting ssh private key is now called id_ed25519

cfergeau commented 3 months ago

Not directly related to this PR, but we also need to update https://github.com/crc-org/crc/wiki/Debugging-guide It's probably better to stop using the algorithm name in the filename so that it's easier to change. id_crc for example instead of id_ed25519

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[test/OWNERS](https://github.com/crc-org/crc/blob/main/test/OWNERS)~~ [cfergeau] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 3 months ago

New changes are detected. LGTM label has been removed.

anjannath commented 3 months ago

updated the commit log to remove the integration as this updates both the e2e and integration files

anjannath commented 3 months ago

/retest

openshift-ci[bot] commented 3 months ago

@anjannath: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 70861e0bab2d557fd9c83495d2825e42b18ccb2a link false /test security
ci/prow/integration-crc 70861e0bab2d557fd9c83495d2825e42b18ccb2a link true /test integration-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).