search

crc-org / crc

CRC is a tool to help you run containers. It manages a local OpenShift 4.x cluster, Microshift or a Podman VM optimized for testing and development purposes
https://crc.dev
Apache License 2.0
1.26k stars 242 forks source link

Upload qe images when code merged to main #4369

Closed lilyLuLiu closed 2 months ago

lilyLuLiu commented 2 months ago

https://github.com/crc-org/crc/issues/4368

lilyLuLiu commented 2 months ago

@adrianriobo Hi, For the windows artifacts action(https://github.com/crc-org/crc/blob/main/.github/workflows/windows-artifacts.yml), I don't get your suggestion: In the windows action, the qe images are built and upload to GitHub action artifacts, instead of quay. And the triggered windows test actions use the qe images from the uploaded artifacts, which requires the workflow id. So the two actions are different. Or you mean we can use quay qe images for windows github action tests?

lilyLuLiu commented 2 months ago

@adrianriobo I have added V in the tag, like vNext-OS-ARCH. We can remove the v after migration to ci-definition.

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianriobo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/crc-org/crc/blob/main/OWNERS)~~ [adrianriobo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 months ago

New changes are detected. LGTM label has been removed.