search

crc-org / crc

CRC is a tool to help you run containers. It manages a local OpenShift 4.x cluster, Microshift or a Podman VM optimized for testing and development purposes
https://crc.dev
Apache License 2.0
1.26k stars 242 forks source link

Ignore virtualization check for arm64 for Linux platform #4437

Closed praveenkumar closed 2 days ago

praveenkumar commented 2 weeks ago

Looks like for arm64 hardware there is no vmx|svm flag which point out if virtualization is enabled from bios or not. There is another way to handle it using virt-host-validate command but that do more test which we might not required. As of now this pr is going to ignore the virtualization check on arm64 to unblock CI for arm.

Fixes: Issue #4433

openshift-ci[bot] commented 2 weeks ago

@praveenkumar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-crc 735b7fc63ae0be0864f106735d24fd46d58fb280 link true /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anjannath

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/crc-org/crc/blob/main/OWNERS)~~ [anjannath] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
cfergeau commented 1 week ago

Fwiw, this would be a good usecase for an "Arch" label https://github.com/crc-org/crc/blob/main/pkg/crc/preflight/labels.go

praveenkumar commented 4 days ago

Fwiw, this would be a good usecase for an "Arch" label https://github.com/crc-org/crc/blob/main/pkg/crc/preflight/labels.go

Right, if in future we need to have different logic for different arch multiple time then we should consider this or you think we should do it this now?