search

crc-org / crc

CRC is a tool to help you run containers. It manages a local OpenShift 4.x cluster, Microshift or a Podman VM optimized for testing and development purposes
https://crc.dev
Apache License 2.0
1.26k stars 242 forks source link

build(deps): bump github.com/golangci/golangci-lint from 1.61.0 to 1.62.0 in /tools #4452

Closed dependabot[bot] closed 46 minutes ago

dependabot[bot] commented 1 week ago

Bumps github.com/golangci/golangci-lint from 1.61.0 to 1.62.0.

Release notes

Sourced from github.com/golangci/golangci-lint's releases.

v1.62.0

golangci-lint is a free and open-source project built by volunteers.

If you value it, consider supporting us, the maintainers and linter authors.

We appreciate it! :heart:

For key updates, see the changelog.

Changelog

  • 29c5529e93f641b6e385b525badb165643f84e10 Add filen linter (#5081)
  • baf610d5bff0c4182e1378310b1d0136f7c04f6a Add iface linter (#4871)
  • ab9076301540d3a794c21f7fe4f87166a1d3bcf8 Add recvcheck linter (#5014)
  • 8a9d16e6e84c4217086ff7c005228e831087406b Revert "Add filen linter (#5081)" (#5087)
  • 944e1d844182da7d93ca5ee31b33d8bcb2e15890 build(deps): bump github.com/Abirdcfly/dupword from 0.1.1 to 0.1.3 (#5062)
  • 9f4951f10d47a35888d5ff84b935e4bc0044b1cf build(deps): bump github.com/Antonboom/errname from 0.1.13 to 1.0.0 (#5057)
  • 61f8c0e8923479d61125e19e103e6d59ddba9139 build(deps): bump github.com/Antonboom/nilnil from 0.1.9 to 1.0.0 (#5058)
  • 095e4952be33b395f273482276275c9fb98fbbe1 build(deps): bump github.com/Antonboom/testifylint from 1.4.3 to 1.5.0 (#5054)
  • 07989418461bc2792e558ce1323164dcf7870afe build(deps): bump github.com/alecthomas/go-check-sumtype from 0.1.4 to 0.2.0 (#5038)
  • 90c0509fcbf07f642d250cdf232d4cd5bf4a657a build(deps): bump github.com/alexkohler/nakedret/v2 from 2.0.4 to 2.0.5 (#5076)
  • 188d56c611e1509335c602da844f829fc996d52b build(deps): bump github.com/bkielbasa/cyclop from 1.2.1 to 1.2.3 (#5071)
  • b020f7b6559f9e37a334e3e7d096aa78e452e100 build(deps): bump github.com/breml/bidichk from 0.2.7 to 0.3.1 (#5025)
  • 6c0ee25a61a03c57f65eb05619529181b0990229 build(deps): bump github.com/breml/bidichk from 0.3.1 to 0.3.2 (#5075)
  • e5dab8de7f74e802662e631a53b3172c5c4638c6 build(deps): bump github.com/breml/errchkjson from 0.3.6 to 0.4.0 (#5028)
  • 318d78e2ba891735574e8bb75b67064712381a99 build(deps): bump github.com/ckaznocha/intrange from 0.2.0 to 0.2.1 (#5024)
  • 5034dbcde1a53f239947e2ab266fc0c8dbc35861 build(deps): bump github.com/fatih/color from 1.17.0 to 1.18.0 (#5088)
  • a33f7942e6572107696badd8f77b351213b52e45 build(deps): bump github.com/ghostiam/protogetter from 0.3.6 to 0.3.8 (#5026)
  • b07c319f557d0496d184f58b3de3d76e19733ef2 build(deps): bump github.com/go-critic/go-critic from 0.11.4 to 0.11.5 (#5061)
  • a45560d4398b2c7c915bb3fd118aec4d8cbe36a2 build(deps): bump github.com/go-viper/mapstructure/v2 from 2.1.0 to 2.2.0 (#5034)
  • aa669e22908160f8780ca56e8925368898b5091e build(deps): bump github.com/go-viper/mapstructure/v2 from 2.2.0 to 2.2.1 (#5040)
  • 8a9cdad5a3544e16b77b6f470e57934e1e9af301 build(deps): bump github.com/golangci/go-printf-func-name from 7558a9eaa5af to v0.1.0 (#5079)
  • 9966cab93c8dda6ed8d5274d3ae876411802578c build(deps): bump github.com/kisielk/errcheck from 1.7.0 to 1.8.0 (#5074)
  • 84c203aa8db22b72207bdf90b454a1c2867a8a12 build(deps): bump github.com/lasiar/canonicalheader from 1.1.1 to 1.1.2 (#5119)
  • fb37d4c0e3c9fffe14cffd5a93bb05356a088bb8 build(deps): bump github.com/mgechev/revive from 1.3.9 to 1.4.0 (#5035)
  • 6ba5f63d284699fec7cbb619d20b9b8b7d66b652 build(deps): bump github.com/mgechev/revive from 1.4.0 to 1.5.0 (#5113)
  • ce9bbe39feb9a980fb5c789272f5108ee470a62a build(deps): bump github.com/nunnatsa/ginkgolinter from 0.16.2 to 0.17.0 (#5093)
  • c4b6d3716e75b1a4ab4485d9cd3102125bf88e71 build(deps): bump github.com/nunnatsa/ginkgolinter from 0.17.0 to 0.18.0 (#5114)
  • 225f7a06f26901f66539bf46fb04206cf53fc192 build(deps): bump github.com/securego/gosec/v2 from 2.21.2 to 2.21.3 (#5029)
  • 3a69806aa2728759460a9b4e4d345bab72635c03 build(deps): bump github.com/securego/gosec/v2 from 2.21.3 to 2.21.4 (#5039)
  • c2f71266b2d3a8a8a158819d7d5973345186794b build(deps): bump github.com/sivchari/tenv from 1.10.0 to 1.12.1 (#5090)
  • 7187c89d4091640f7587acf416e82fd87ff96839 build(deps): bump github.com/sonatard/noctx from 0.0.2 to 0.1.0 (#5027)
  • 5451909f23ceea6e619b2e5d087bce203fae377b build(deps): bump github.com/tetafro/godot from 1.4.17 to 1.4.18 (#5002)
  • d68c333bc1148f14836b856e233944908fda2b6e build(deps): bump github.com/timonwong/loggercheck from 0.9.4 to 0.10.1 (#5094)
  • 22b58c9b648f027d699f305c069a2a97ed0c5b06 build(deps): bump go-simpler.org/musttag from 0.12.2 to 0.13.0 (#5121)
  • 46db787df4c1d53e749e727ce7754e810e337555 build(deps): bump go.uber.org/automaxprocs from 1.5.3 to 1.6.0 (#5041)
  • 02a536a4ef330430bba9d01a40aa9ef419652bd1 build(deps): bump golang.org/x/sys from 0.26.0 to 0.27.0 (#5118)
  • b3a1e1c836151d09db3b6519199ab089feb817fe build(deps): bump golang.org/x/tools from 0.24.0 to 0.25.0 (#5001)
  • 10f281c1fd4a679d88b0a01dd6038357b58d0a00 build(deps): bump golang.org/x/tools from 0.25.0 to 0.26.0 (#5056)
  • 0f4f0cb075b93b1c146f399c0cb811edf8364d78 build(deps): bump golang.org/x/tools from 0.26.0 to 0.27.0 (#5120)
  • 31f2714643a1a5f0ad746ff782bacd5d0af94534 build(deps): bump golangci/golangci-lint-action from 6.1.0 to 6.1.1 in the all group (#5059)

... (truncated)

Changelog

Sourced from github.com/golangci/golangci-lint's changelog.

v1.62.0

  1. New linters
  2. Updated linters
    • ⚠️ execinquery: deprecation step 2
    • ⚠️ gomnd: deprecation step 2 (replaced by mnd)
    • bidichk: from 0.2.7 to 0.3.2 (important performance improvement)
    • canonicalheader: from 1.1.1 to 1.1.2
    • cyclop: from 1.2.1 to 1.2.3
    • dupword: from 0.1.1 to 0.1.3
    • errcheck: from 1.7.0 to 1.8.0
    • errchkjson: from 0.3.6 to 0.4.0
    • errname: from 0.1.13 to 1.0.0
    • ginkgolinter: from 0.17.0 to 0.18.0 (new option: force-succeed)
    • go-check-sumtype: from 0.1.4 to 0.2.0 (new option: default-signifies-exhaustive)
    • go-critic: from 0.11.4 to 0.11.5
    • go-printf-func-name: from 7558a9eaa5af to v0.1.0
    • godot: from 1.4.17 to 1.4.18
    • gosec: from 2.21.2 to 2.21.4
    • intrange: from 0.2.0 to 0.2.1
    • loggercheck: from 0.9.4 to 0.10.1 (log/slog support)
    • musttag: from 0.12.2 to 0.13.0
    • nakedret: from 2.0.4 to 2.0.5
    • nilnil: from 0.1.9 to 1.0.0 (new option: detect-opposite)
    • noctx: from 0.0.2 to 0.1.0
    • protogetter: from 0.3.6 to 0.3.8
    • revive: from 1.3.9 to 1.5.0 (new rules: filename-format, and file-length-limit)
    • tenv: from 1.10.0 to 1.12.1 (handle dot import)
    • testifylint: from 1.4.3 to 1.5.0 (new checkers: contains, encoded-compare, regexp)
  3. Misc.
    • Type sizing when cross-compiling (32-bit).
    • code-climate: add check_name field
    • Improve Go version detection
    • Fix Go version propagation
  4. Documentation
    • Adds a section about exclude-dirs-use-default
    • Improve 'install from sources' section
    • Improve FAQ about Go versions
    • Improve linter/rule/check docs
    • Improve new linter section
    • Improve forbidigo pattern examples for built-in functions
Commits
  • 22b58c9 build(deps): bump go-simpler.org/musttag from 0.12.2 to 0.13.0 (#5121)
  • 84c203a build(deps): bump github.com/lasiar/canonicalheader from 1.1.1 to 1.1.2 (#5119)
  • 0f4f0cb build(deps): bump golang.org/x/tools from 0.26.0 to 0.27.0 (#5120)
  • 02a536a build(deps): bump golang.org/x/sys from 0.26.0 to 0.27.0 (#5118)
  • b46ad10 docs: improve forbidigo pattern examples for built-in functions (#5116)
  • 8c0c515 fix: Go version propagation (#5109)
  • 874a8ba feat: deprecation step 2 of execinquery and gomnd (#5110)
  • 6ba5f63 build(deps): bump github.com/mgechev/revive from 1.4.0 to 1.5.0 (#5113)
  • c4b6d37 build(deps): bump github.com/nunnatsa/ginkgolinter from 0.17.0 to 0.18.0 (#5114)
  • 7560b4f fix: improve Go detection (#5112)
  • Additional commits viewable in compare view


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
openshift-ci[bot] commented 1 week ago

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a crc-org member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
cfergeau commented 1 week ago

This introduces 2 new lint errors

 Error: #10 179.7 pkg/extract/extract.go:88:1: redefines-builtin-id: redefinition of the built-in function min (revive)
#10 179.7 func min(a int64, b int64) int64 {
#10 179.7   if a < b {
#10 179.7       return a
#10 179.7   }
#10 179.7   return b
#10 179.7 }
Error: #10 179.7 pkg/crc/cluster/clusteroperator.go:74:1: redefines-builtin-id: redefinition of the built-in function min (revive)
#10 179.7 func min(a, b int) int {
#10 179.7   if a > b {
#10 179.7       return b
#10 179.7   }
#10 179.7   return a
#10 179.7 }
praveenkumar commented 1 week ago

/hold

cfergeau commented 2 days ago

/unhold

cfergeau commented 2 days ago

/lgtm /approve

openshift-ci[bot] commented 2 days ago

@dependabot[bot]: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images ea5338a60e07501d4f12dc2bbbb29cec4a90c8ac link true /test images
ci/prow/security ea5338a60e07501d4f12dc2bbbb29cec4a90c8ac link false /test security
ci/prow/e2e-crc ea5338a60e07501d4f12dc2bbbb29cec4a90c8ac link true /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
cfergeau commented 58 minutes ago

Ah messed up my push, thanks! /lgtm /approve

openshift-ci[bot] commented 58 minutes ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/crc-org/crc/blob/main/OWNERS)~~ [cfergeau] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment