feat (dns) : Add `host.crc.testing` to `/etc/hosts` (#4410)

rohanKanojia commented 1 day ago

Fixes: Issue #4410 Relates to: Issue #4410

Solution/Idea

Add another entry in /etc/hosts/ for host.crc.testing domain as suggested in https://github.com/crc-org/crc/issues/4410#issuecomment-2431907547

Proposed changes

Add another method GetHostName() to CrcBundleInfo struct in order to provide host domain
Use abovementioned method in dns.addOpenShiftHosts in order to add another dns entry for host.crc.testing

Testing

After doing crc start you'd notice an additional entry in /etc/hosts for host.crc.testing

Old state of /etc/hosts

# Added by CRC
192.168.130.11   api.crc.testing canary-openshift-ingress-canary.apps.crc.testing console-openshift-console.apps.crc.testing default-ro
ute-openshift-image-registry.apps.crc.testing downloads-openshift-console.apps.crc.testing oauth-openshift.apps.crc.testing
# End of CRC section

New state of /etc/hosts (after these changes):

# Added by CRC
192.168.130.11   api.crc.testing canary-openshift-ingress-canary.apps.crc.testing console-openshift-console.apps.crc.testing default-route-openshift-image-registry.apps.crc.testing downloads-openshift-console.apps.crc.testing host.crc.testing oauth-openshift.apps.crc.testing
# End of CRC section

openshift-ci[bot] commented 1 day ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign evidolob for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/crc-org/crc/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

openshift-ci[bot] commented 1 day ago

Hi @rohanKanojia. Thanks for your PR.

I'm waiting for a crc-org member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

crc-org / crc