search

crc-org / machine-driver-hyperkit

Machine driver for hyperkit
Apache License 2.0
5 stars 3 forks source link

Implement UpdateConfigRaw in hyperkit driver #19

Closed cfergeau closed 4 years ago

cfergeau commented 4 years ago

This will make it possible to update memory size/cpu count of the VM.

praveenkumar commented 4 years ago

Run go mod tidy should be part of https://github.com/code-ready/machine-driver-hyperkit/pull/19/commits/d3a63490379810344716f8b2090abc308b6f6e55 one where we are updating the machine version to go.mod instead of a separate commit message.

cfergeau commented 4 years ago

Run go mod tidy should be part of d3a6349 one where we are updating the machine version to go.mod instead of a separate commit message.

Running git mod tidy on current master (before this patch series) generates a similar diff to the dedicated commit in this PR, so the go mod tidy change is not related to the other commits in this PR. I'll squash it as it's not so important

praveenkumar commented 4 years ago

https://github.com/code-ready/machine-driver-hyperkit/pull/19/commits/d1eea888da3be4a6567acdbf489ed0e25fd8f7aa logs says Set driver version to 0.12.9 but it should be 0.12.8