crc-org / osp4

Proof of Concept repository of CodeReady Containers [Archived]
Apache License 2.0
26 stars 16 forks source link

Support KubeVirt #21

Open fabiand opened 5 years ago

fabiand commented 5 years ago

KubeVirt is like libvirt on a cluster.

Maybe it's easy to clone the libvirt provider to also support KubeVirt.

gbraad commented 5 years ago

This is certainly a thought that crossed my mind also, but this is also a general issue with there not beoing a Cluster API provider. Is this planned? Is this even a realistic usecase?

praveenkumar commented 5 years ago

@fabiand I am not very clear about this issue, do you want to have kubevirt by default there as part of disk image? My understanding is, we are going to provide minimal setup for openshift and if you want any adition component then add it on top.

Does kubevirt already converted as operator for Openshift?

fabiand commented 5 years ago

First - I merely filed this to see how the echo on the idea is :)

@gbraad Well, there is this work https://github.com/kubermatic/machine-controller/pull/420/ which might help

@praveenkumar Well, it's not about installing KubeVirt ontop of OCP4, this issue is about using kubevirt as a backend for the ocp installer.

praveenkumar commented 5 years ago

Well, it's not about installing KubeVirt ontop of OCP4, this issue is about using kubevirt as a backend for the ocp installer.

@fabiand ah, in that case doesn't this should be part of actual installer repo => https://github.com/openshift/installer/issues ?

gbraad commented 5 years ago

right, I had the same answer. also, work that should be considered is that the installer does initial deployment of a target infrastructure using Terraform (ATM). After this, the installer targets these nodes with RHCOS and a config, and sets up the cluster. After this is finished, the cluster can be maintained and expanded using the the cluster API.

fabiand commented 5 years ago

Maybe the funny thing is that with kubevirt we could deliver OKD on any kubernetes cluster ;) (where kubevirt runs)

fabiand commented 5 years ago

@gbraad thanks for this explanation.

I'll close this bug, not sure if opening it on installre will stirr to much noise.

gbraad commented 5 years ago

I am pretty sure they will respond it is NOT an installer isue, but rather openshift/os to get RHCOS to support Kubevirt.

fabiand commented 5 years ago

Right, KubeVirt should be able to run RHCOS (should be able to do s right now), but then it's still about letting terraform (?) being able to speak to kubevirt to lay out th enodes. Not?

gbraad commented 5 years ago

right. terraform is now currently embedded with the libvirt provider, but long term the idea would be to drop terraform. if there is a way to create the VMs in an easy way, abstracted, this might help. you already mentioned the libvirt provider would need to be forked? how different is it?

On Fri, Jan 25, 2019 at 5:26 PM Fabian Deutsch notifications@github.com wrote:

Right, KubeVirt should be able to run RHCOS (should be able to do s right now), but then it's still about letting terraform (?) being able to speak to kubevirt to lay out th enodes. Not?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

--

Gerard Braad | http://gbraad.nl [ Doing Open Source Matters ]

fabiand commented 5 years ago

KubeVirt has a different APi than libvirt, obviously. But if you can create a libvirt VM, hten it's pretty trivial to create a KubeVirt VM from it. Images can be reused 1:1 and domxml/definition can be tranformed into a kubevirt ylma (best would be to do it the other way round: domxml from kubevirt yalm).