search

crc-org / osp4

Proof of Concept repository of CodeReady Containers [Archived]
Apache License 2.0
26 stars 16 forks source link

crc-libvirt: Use conf.d directory #36

Closed cgwalters closed 5 years ago

cgwalters commented 5 years ago

Use the conf.d directory rather than changing the main config which will be fragile.

Tweak things to be more idempotent too.

cgwalters commented 5 years ago

(Totally untested)

praveenkumar commented 5 years ago

Thanks, I will test that tomorrow and merge it.

gbraad commented 5 years ago

You might also wanna change this in the installer libvirt-howto.md

zeenix commented 5 years ago

You might also wanna change this in the installer libvirt-howto.md

Done! @cgwalters would you update your patch according to those changes or shall i create another PR?

gbraad commented 5 years ago

Which changes are you suggesting?

zeenix commented 5 years ago

Which changes are you suggesting?

At least the '[main]' is missing from Collin's patch. :)

gbraad commented 5 years ago

I think you can add this as a patch on top or rebase/amend. Colin is usually quite busy...

On Fri, Feb 15, 2019, 18:52 Zeeshan Ali notifications@github.com wrote:

Which changes are you suggesting?

At least the '[main]' is missing from Collin's patch. :)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/code-ready/osp4/pull/36#issuecomment-463997575, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAHZmATiYD_CIJUemOJjjSkDkk6SUuJks5vNpF9gaJpZM4a5kQJ .

zeenix commented 5 years ago

I think you can add this as a patch on top or rebase/amend.

I can push to his branch?

gbraad commented 5 years ago

this happened, right?

zeenix commented 5 years ago

this happened, right?

nope! it was forgotten.

zeenix commented 5 years ago

Now we can close this in favour of #49.