crc-org / osp4

Proof of Concept repository of CodeReady Containers [Archived]
Apache License 2.0
26 stars 16 forks source link

Remove Minishift naming as projects are unrelated #37

Closed gbraad closed 5 years ago

gbraad commented 5 years ago

please go ahead and change it

On Tue, Feb 19, 2019 at 1:20 PM Lalatendu Mohanty notifications@github.com wrote:

@LalatenduMohanty commented on this pull request.

In README.md https://github.com/code-ready/osp4/pull/37#discussion_r258034411:

@@ -11,13 +11,13 @@ Note: Experimental for Mac and Linux

Steps

  • set up environment:
    
    -$ export KUBECONFIG=/path/to/minishit_virtualbox_0.9.1/
    -$ chmod +x ./minishift_virtualbox.sh
    +$ export KUBECONFIG=/path/to/crc_virtualbox_0.9.1/

Somehow missed it when I changed strings from minishift to crc. Also I agree with @praveenkumar https://github.com/praveenkumar

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/code-ready/osp4/pull/37#discussion_r258034411, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAHZlfkVoj4gtpHkt6drkXA5VodfPNcks5vO_o2gaJpZM4bAIlH .

--

Gerard Braad | http://gbraad.nl [ Doing Open Source Matters ]