crc-org / snc

Single Node Cluster creation scripts for OpenShift 4.x as used by CodeReady Containers
https://crc.dev
Apache License 2.0
100 stars 49 forks source link

[OpenShift] Add arch info when downloading the podman remote client binary #525

Open praveenkumar opened 2 years ago

praveenkumar commented 2 years ago

https://github.com/containers/podman/releases/tag/v4.0.2 now have arch info in the remote binary tarball which was not there during 3.x releases so we need to update our podman bundle creation stuff accordingly.

+ curl -L https://github.com/containers/podman/releases/download/v4.0.2/podman-remote-release-darwin.zip -o podman-remote/mac/podman.zip
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100     9  100     9    0     0     79      0 --:--:-- --:--:-- --:--:--    78
+ unzip -o -d podman-remote/mac/ podman-remote/mac/podman.zip
Archive:  podman-remote/mac/podman.zip
  End-of-central-directory signature not found.  Either this file is not
  a zipfile, or it constitutes one disk of a multi-part archive.  In the
  latter case the central directory and zipfile comment will be found on
  the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of podman-remote/mac/podman.zip or
        podman-remote/mac/podman.zip.zip, and cannot find podman-remote/mac/podman.zip.ZIP, period.
praveenkumar commented 2 years ago

This is fixed on podman branch.

praveenkumar commented 2 years ago

I will keep it open when OCP/OKD migrate to podman-4.x