search

crc-org / snc

Single Node Cluster creation scripts for OpenShift 4.x as used by CodeReady Containers
https://crc.dev
Apache License 2.0
100 stars 49 forks source link

Remove hack around MCO .orig file #833

Closed praveenkumar closed 5 months ago

praveenkumar commented 6 months ago

https://issues.redhat.com/browse/OCPBUGS-11437 is now fixed which means we no longer need to use the workaround to update .orig file of pull secret to have it replace with a dummy one.

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gbraad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/crc-org/snc/blob/release-4.15/OWNERS)~~ [gbraad] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
cfergeau commented 6 months ago

Have you checked that the https://issues.redhat.com/browse/OCPBUGS-11437 fix is working fine for our use case? Ie that this won't reintroduce a leak of the pull secret?

praveenkumar commented 6 months ago

@cfergeau with this fix there is no .orig file generated for pull secret and we are going to test the bundle using this PR if there is still leak of the pull secret.

praveenkumar commented 6 months ago

/retest

openshift-ci[bot] commented 6 months ago

@praveenkumar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-snc 91266be7efd1fc477299cb7697f1f6cbc764a182 link true /test e2e-snc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
cfergeau commented 6 months ago

@cfergeau with this fix there is no .orig file generated for pull secret and we are going to test the bundle using this PR if there is still leak of the pull secret.

If this does not reintroduce a pull secret leak, looks good to me.

praveenkumar commented 5 months ago

If this does not reintroduce a pull secret leak, looks good to me.

I run the rh-leaks on this bundle (shared on internal slack) and didn't see any pull secret leak so merging it now.