crc-org / snc

Single Node Cluster creation scripts for OpenShift 4.x as used by CodeReady Containers
https://crc.dev
Apache License 2.0
100 stars 51 forks source link

should we change storage class reclaim policy to `Retain` #835

Closed anjannath closed 7 months ago

anjannath commented 8 months ago

Prior to 77aa37ee5a74b3cff7506bae3b53292d028073f9 when we pre-created pvs the reclaim policy was set to Recycle but since there wasn't any volume re-cycler configured, the effect was similar to having reclaim policy set to Retain

it'd be better to set the same reclaimPolicy: Retain for the hostpath-provider storage class (currently it is not set and default is Delete), as this will allow users to recover any data after deleting the pvc

this came up in the issue: https://github.com/crc-org/crc/issues/3944