search

crc-org / snc

Single Node Cluster creation scripts for OpenShift 4.x as used by CodeReady Containers
https://crc.dev
Apache License 2.0
100 stars 49 forks source link

tools: Don't generate linux arm64 bundle #836

Closed praveenkumar closed 5 months ago

praveenkumar commented 5 months ago

As of now there is no support on crc side to test and verify Linux arm64 bundles so better to not generate those and if user really want it to generate the can use SNC_GENERATE_LINUX_BUNDLE=1 ./createdisk.sh.

Also in case of downstream CI it will remove addition time of generation that linux bundle.

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from praveenkumar. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/crc-org/snc/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
praveenkumar commented 5 months ago

/cherry-pick release-4.15

openshift-cherrypick-robot commented 5 months ago

@praveenkumar: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you.

In response to [this](https://github.com/crc-org/snc/pull/836#issuecomment-1898180861): >/cherry-pick release-4.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
cfergeau commented 5 months ago

@Prashanth684 since you added arm64 support, but mostly with an Apple Silicon focus, any comments on the removal on linux arm64 bundles?

openshift-ci[bot] commented 5 months ago

@praveenkumar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-microshift 85d727ede61ed0ef442170e593b49dddc367b989 link true /test e2e-microshift
ci/prow/e2e-snc 85d727ede61ed0ef442170e593b49dddc367b989 link true /test e2e-snc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
praveenkumar commented 5 months ago

@Prashanth684 since you added arm64 support, but mostly with an Apple Silicon focus, any comments on the removal on linux arm64 bundles?

Support was added for mac side https://github.com/crc-org/snc/pull/454 , this changes were added by us.

praveenkumar commented 5 months ago

/cherry-pick release-4.15

openshift-cherrypick-robot commented 5 months ago

@praveenkumar: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you.

In response to [this](https://github.com/crc-org/snc/pull/836#issuecomment-1914397959): >/cherry-pick release-4.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-cherrypick-robot commented 5 months ago

@praveenkumar: new pull request created: #843

In response to [this](https://github.com/crc-org/snc/pull/836#issuecomment-1914397959): >/cherry-pick release-4.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.