crc-org / snc

Single Node Cluster creation scripts for OpenShift 4.x as used by CodeReady Containers
https://crc.dev
Apache License 2.0
100 stars 51 forks source link

Move OKD bundle from FCOS to SCOS #840

Closed praveenkumar closed 8 months ago

praveenkumar commented 8 months ago

Since okd-scos is better upstream for OCP than FCOS one. It also have pre-release version of 4.15 so switching OKD bundles to it.

praveenkumar commented 8 months ago

/hold

Looks like the release doesn't contain the windows oc binary (asked on the internal slack about it will update here once get some answer)

openshift-ci[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/crc-org/snc/blob/master/OWNERS)~~ [cfergeau] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 8 months ago

New changes are detected. LGTM label has been removed.

openshift-ci[bot] commented 8 months ago

@praveenkumar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-snc 0b03587534f17147a5cd698e30844bfd5e0e72ca link true /test e2e-snc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
praveenkumar commented 8 months ago

/unhold

going to merge to create OKD bundle for test.

praveenkumar commented 8 months ago

/cherry-pick release-4.15

openshift-cherrypick-robot commented 8 months ago

@praveenkumar: new pull request created: #842

In response to [this](https://github.com/crc-org/snc/pull/840#issuecomment-1907964012): >/cherry-pick release-4.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.