crc-org / snc

Single Node Cluster creation scripts for OpenShift 4.x as used by CodeReady Containers
https://crc.dev
Apache License 2.0
100 stars 49 forks source link

Switch Network type from OpenShiftSDN to OVNKubernetes #851

Closed praveenkumar closed 4 months ago

praveenkumar commented 5 months ago

With 4.15, OpenShiftSDN network plugin removed and OVNKubernetes is only option which is supported.

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from praveenkumar. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/crc-org/snc/blob/release-4.15/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
praveenkumar commented 5 months ago

/retest

openshift-ci[bot] commented 5 months ago

@praveenkumar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-snc 54d864ffd5724666d7019967c2fb101dc0097715 link true /test e2e-snc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
adrianriobo commented 5 months ago

Test passed for the bundle with OVNKubernets, also I notice due to some code it set the memory to 12G, I will run it again with defaults to ensure it also passes with default values.

adrianriobo commented 4 months ago

This has been tested and cluster eventually comes up with default resources. But it shows several issues during start, bit more of tested is required.

https://crcqe-asia.s3.ap-south-1.amazonaws.com/nightly/ocp/4.15.0-rc.5/qe-results/e2e-non-ux.xml

adrianriobo commented 4 months ago

Indeed with current defaults I am not able to properly start the cluster :( even after 30 minutes operators are not able to stabilize)

adrianriobo commented 4 months ago

I need to setup

crc config set memory 11000

otherwise I am not able to get a running state for the cluster :(

^^ @praveenkumar

cfergeau commented 4 months ago

https://github.com/crc-org/snc/pull/812 has:

As per https://issues.redhat.com/browse/OCPBUGS-5945 looks like OVN-K have reduced footprint in case of SNO and with PR we are going to be true SNO so we can make use of it and have OVN-K as default network plugin.

Would #812 help with the resource issues seen in this PR?

praveenkumar commented 4 months ago

812 has:

As per https://issues.redhat.com/browse/OCPBUGS-5945 looks like OVN-K have reduced footprint in case of SNO and with PR we are going to be true SNO so we can make use of it and have OVN-K as default network plugin.

Would #812 help with the resource issues seen in this PR?

No, it is not help with resource utilization because it have same memory/cpu footprint for ovnk pods.

cfergeau commented 4 months ago

812 has:

As per https://issues.redhat.com/browse/OCPBUGS-5945 looks like OVN-K have reduced footprint in case of SNO and with PR we are going to be true SNO so we can make use of it and have OVN-K as default network plugin.

Would #812 help with the resource issues seen in this PR?

No, it is not help with resource utilization because it have same memory/cpu footprint for ovnk pods.

This text can be removed from the rationale for using SNO then:

As per https://issues.redhat.com/browse/OCPBUGS-5945 looks like OVN-K have reduced footprint in case of SNO and with PR we are going to be true SNO so we can make use of it and have OVN-K as default network plugin.

praveenkumar commented 4 months ago

Closing since we are moving from libvirt IPI to SNO where it is by default OVN-K