search

crc-org / snc

Single Node Cluster creation scripts for OpenShift 4.x as used by CodeReady Containers
https://crc.dev
Apache License 2.0
100 stars 51 forks source link

Remove kernel downgrade logic for vfkit bundles #890

Closed praveenkumar closed 4 months ago

praveenkumar commented 4 months ago

We already put warning around 3 release before for crc side that macOS < 13 is not supported and try to update the os. With this PR, kernel downgrade logic is removed which is required for macos<13.

Bundle created using this PR will not work for macos less than 13.x.

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from praveenkumar. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/crc-org/snc/blob/release-4.15/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
praveenkumar commented 4 months ago

/retest

openshift-ci[bot] commented 4 months ago

@praveenkumar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-snc 5574462b8815f0f02efc83925c1fe00f1a571357 link true /test e2e-snc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
praveenkumar commented 4 months ago

/cherry-pick release-4.16

openshift-cherrypick-robot commented 4 months ago

@praveenkumar: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you.

In response to [this](https://github.com/crc-org/snc/pull/890#issuecomment-2133345692): >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
praveenkumar commented 4 months ago

/cherry-pick master

openshift-cherrypick-robot commented 4 months ago

@praveenkumar: once the present PR merges, I will cherry-pick it on top of master in a new PR and assign it to you.

In response to [this](https://github.com/crc-org/snc/pull/890#issuecomment-2133345890): >/cherry-pick master Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-cherrypick-robot commented 4 months ago

@praveenkumar: #890 failed to apply on top of branch "master":

Applying: Remove kernel downgrade logic for vfkit bundles
Using index info to reconstruct a base tree...
M   createdisk-library.sh
M   createdisk.sh
Falling back to patching base and 3-way merge...
Auto-merging createdisk.sh
Auto-merging createdisk-library.sh
CONFLICT (content): Merge conflict in createdisk-library.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Remove kernel downgrade logic for vfkit bundles
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/crc-org/snc/pull/890#issuecomment-2133345890): >/cherry-pick master Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-cherrypick-robot commented 4 months ago

@praveenkumar: #890 failed to apply on top of branch "release-4.16":

Applying: Remove kernel downgrade logic for vfkit bundles
Using index info to reconstruct a base tree...
M   createdisk-library.sh
M   createdisk.sh
Falling back to patching base and 3-way merge...
Auto-merging createdisk.sh
Auto-merging createdisk-library.sh
CONFLICT (content): Merge conflict in createdisk-library.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Remove kernel downgrade logic for vfkit bundles
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/crc-org/snc/pull/890#issuecomment-2133345692): >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.