search

crc-org / snc

Single Node Cluster creation scripts for OpenShift 4.x as used by CodeReady Containers
https://crc.dev
Apache License 2.0
103 stars 50 forks source link

[master] Remove kernel downgrade logic for vfkit bundles #898

Closed praveenkumar closed 6 months ago

praveenkumar commented 6 months ago

We already put warning around 3 release before for crc side that macOS < 13 is not supported and try to update the os. With this PR, kernel downgrade logic is removed which is required for macos<13.

Bundle created using this PR will not work for macos less than 13.x.

Manual cherry-picked because it failed automatic https://github.com/crc-org/snc/pull/890#issuecomment-2133349717

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from praveenkumar. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/crc-org/snc/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
praveenkumar commented 6 months ago

/cherry-pick release-4.16

openshift-cherrypick-robot commented 6 months ago

@praveenkumar: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you.

In response to [this](https://github.com/crc-org/snc/pull/898#issuecomment-2136633192): >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-cherrypick-robot commented 6 months ago

@praveenkumar: new pull request created: #899

In response to [this](https://github.com/crc-org/snc/pull/898#issuecomment-2136633192): >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.