search

crc-org / snc

Single Node Cluster creation scripts for OpenShift 4.x as used by CodeReady Containers
https://crc.dev
Apache License 2.0
100 stars 49 forks source link

CI: update golang container image to v1.21 #906

Closed praveenkumar closed 3 weeks ago

praveenkumar commented 3 weeks ago

crc codebase now uses go-1.21 and it fails to build with go-1.20 now.

Should fix following error in CI

OARCH=arm64 GOOS=darwin go build -tags "containers_image_openpgp" -ldflags="-X github.com/crc-org/crc/v2/pkg/crc/version.crcVersion=2.37.0 -X github.com/crc-org/crc/v2/pkg/crc/version.ocpVersion=4.15.14 -X github.com/crc-org/crc/v2/pkg/crc/version.okdVersion=4.15.0-0.okd-2024-02-23-163410 -X github.com/crc-org/crc/v2/pkg/crc/version.microshiftVersion=4.15.14 -X github.com/crc-org/crc/v2/pkg/crc/version.commitSha=c74697 " -o out/macos-arm64/crc  ./cmd/crc
vendor/github.com/containers/image/v5/pkg/blobinfocache/internal/prioritize/prioritize.go:6:2: package cmp is not in GOROOT (/usr/lib/golang/src/cmp)
note: imported by a module that requires go 1.21
vendor/github.com/containers/image/v5/internal/signature/sigstore.go:6:2: package maps is not in GOROOT (/usr/lib/golang/src/maps)
note: imported by a module that requires go 1.21
vendor/github.com/containers/image/v5/internal/pkg/platform/platform_matcher.go:24:2: package slices is not in GOROOT (/usr/lib/golang/src/slices)
note: imported by a module that requires go 1.21
praveenkumar commented 3 weeks ago

/cherry-pick release-4.16

openshift-cherrypick-robot commented 3 weeks ago

@praveenkumar: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you.

In response to [this](https://github.com/crc-org/snc/pull/906#issuecomment-2162469787): >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
praveenkumar commented 3 weeks ago

/cherry-pick release-4.15

openshift-cherrypick-robot commented 3 weeks ago

@praveenkumar: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you.

In response to [this](https://github.com/crc-org/snc/pull/906#issuecomment-2162470294): >/cherry-pick release-4.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
cfergeau commented 3 weeks ago

/approve /lgtm

openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/crc-org/snc/blob/master/OWNERS)~~ [cfergeau] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 3 weeks ago

@praveenkumar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-snc 3abf868026cc3df5cdb8a99702d0f2464b30b1b6 link true /test e2e-snc
ci/prow/e2e-microshift 3abf868026cc3df5cdb8a99702d0f2464b30b1b6 link true /test e2e-microshift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-cherrypick-robot commented 3 weeks ago

@praveenkumar: new pull request created: #907

In response to [this](https://github.com/crc-org/snc/pull/906#issuecomment-2162469787): >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-cherrypick-robot commented 3 weeks ago

@praveenkumar: #906 failed to apply on top of branch "release-4.15":

Applying: CI: update golang container image to v1.21
Using index info to reconstruct a base tree...
M   ci.sh
M   ci_microshift.sh
Falling back to patching base and 3-way merge...
Auto-merging ci_microshift.sh
CONFLICT (content): Merge conflict in ci_microshift.sh
Auto-merging ci.sh
CONFLICT (content): Merge conflict in ci.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 CI: update golang container image to v1.21
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/crc-org/snc/pull/906#issuecomment-2162470294): >/cherry-pick release-4.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.