search

crc-org / snc

Single Node Cluster creation scripts for OpenShift 4.x as used by CodeReady Containers
https://crc.dev
Apache License 2.0
100 stars 51 forks source link

Only use qemu-guest-agent on macos #914

Closed cfergeau closed 3 months ago

cfergeau commented 3 months ago

On linux/windows, we don't setup the needed vsock devices, so qemu-guest-agent fails to start. We can use ConditionVirtualization=apple to only start it when running on a mac.

praveenkumar commented 3 months ago

@cfergeau this we used for time sync on the mac right?

cfergeau commented 3 months ago

@cfergeau this we used for time sync on the mac right?

Yes. Maybe this can be solved in a simpler way with makestep -1 in chrony configuration, I haven't re-tested this.

praveenkumar commented 3 months ago

makestep -1

Just looked the man chrony.conf and got following which sound promising and we don't need to that configuration of the guest-agent if that works as expected, how does podman machine handle time drift in mac?

           Normally chronyd will cause the system to gradually correct any time offset, by slowing down or speeding up the
           clock as required. In certain situations, e.g. when chronyd is initially started, the system clock might be so
           far adrift that this slewing process would take a very long time to correct the system clock.

           This directive forces chronyd to step the system clock if the adjustment is larger than a threshold value, but
           only if there were no more clock updates since chronyd was started than the specified limit. A negative value
           disables the limit.

           On most systems it is desirable to step the system clock only on boot, before starting programs that rely on
           time advancing monotonically forwards.

           An example of the use of this directive is:

               makestep 0.1 3

           This would step the system clock if the adjustment is larger than 0.1 seconds, but only in the first three
           clock updates.

Should we create an issue and set it as good first one for some new team members to try it out?

cfergeau commented 3 months ago

Just looked the man chrony.conf and got following which sound promising and we don't need to that configuration of the guest-agent if that works as expected, how does podman machine handle time drift in mac?

Last I checked, they were using makestep

cfergeau commented 3 months ago

Just looked the man chrony.conf and got following which sound promising and we don't need to that configuration of the guest-agent if that works as expected, how does podman machine handle time drift in mac?

Last I checked, they were using makestep

The corresponding podman issue was https://github.com/containers/podman/issues/11541

openshift-ci[bot] commented 3 months ago

@cfergeau: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-microshift bdc3e5eeb305c67698d1440b0d22768acf5a8c26 link true /test e2e-microshift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
praveenkumar commented 3 months ago

Created https://github.com/crc-org/snc/issues/916 one and we can have this PR in for time being.

praveenkumar commented 3 months ago

/cherry-pick release-4.16

openshift-cherrypick-robot commented 3 months ago

@praveenkumar: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you.

In response to [this](https://github.com/crc-org/snc/pull/914#issuecomment-2175549205): >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
praveenkumar commented 3 months ago

/cherry-pick release-4.15

openshift-cherrypick-robot commented 3 months ago

@praveenkumar: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you.

In response to [this](https://github.com/crc-org/snc/pull/914#issuecomment-2175549574): >/cherry-pick release-4.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: praveenkumar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/crc-org/snc/blob/master/OWNERS)~~ [praveenkumar] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-cherrypick-robot commented 3 months ago

@praveenkumar: new pull request created: #917

In response to [this](https://github.com/crc-org/snc/pull/914#issuecomment-2175549205): >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-cherrypick-robot commented 3 months ago

@praveenkumar: new pull request created: #918

In response to [this](https://github.com/crc-org/snc/pull/914#issuecomment-2175549574): >/cherry-pick release-4.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.