crc-org / snc

Single Node Cluster creation scripts for OpenShift 4.x as used by CodeReady Containers
https://crc.dev
Apache License 2.0
103 stars 50 forks source link

[release-4.16]Revert "build-patched-kao-kcmo-images.sh: get image name from brew container image metadata #915

Closed praveenkumar closed 4 months ago

praveenkumar commented 5 months ago

This reverts commit a2b6ece823dfade602a128585e477fbdf6ac56ab.

Revert "kao-kcmo-images.sh: Don't hardcode the image name"

This reverts commit d4ca7af70589d951ec19df5363da52b1757ff307.

Revert "kao-kcmo-images.sh: Add reference for image_from_brew variable"

This reverts commit 8c64f2d9e24713c615a92f40376d39f4a0ab23cf.

We need to revert since the metadata file is not available for quite some time even after the brew build successful and CI is failing because of that with following error.

++ curl -L https://download.eng.bos.redhat.com/brewroot/packages/crc-cluster-kube-apiserver-operator-container/v4.15.0/202406052127.p0.geae6926.assembly.stream.el9/metadata.json
++ jq -r '.build.extra.image.index.pull[0]'
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100   328  100   328    0     0   2000      0 --:--:-- --:--:-- --:--:--  2012
parse error: Invalid numeric literal at line 1, column 10
openshift-ci[bot] commented 5 months ago

@praveenkumar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-microshift 306f0e657fc5095f4d586c16fa5c2e1a21e25a25 link true /test e2e-microshift
ci/prow/e2e-snc 306f0e657fc5095f4d586c16fa5c2e1a21e25a25 link true /test e2e-snc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
cfergeau commented 4 months ago

This isn't merged yet, but I believe 4.16 bundles were successfully generated anyway? Do we need this change?

praveenkumar commented 4 months ago

This isn't merged yet, but I believe 4.16 bundles were successfully generated anyway? Do we need this change?

patched images are generated using current 4.16 branch but we needed to perform same build 2 times with 15-20 mins duration to have it available. So yes we still need this change.

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/crc-org/snc/blob/release-4.16/OWNERS)~~ [cfergeau] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment