crc-org / snc

Single Node Cluster creation scripts for OpenShift 4.x as used by CodeReady Containers

https://crc.dev

Apache License 2.0

103 stars 50 forks source link

[release-4.16] Delete pods and lease using etcd container #936

Closed praveenkumar closed 2 months ago

praveenkumar commented 4 months ago

As of now when user consume the bundle to provision the cluster, old data around pods and lease is consumed and timestamp for those pods are also around same time when we first provisioned this cluster. This PR try to use etcd image to run etcd server using same db which created by the cluster and uses etcdctl command to delete the pods and lease details. It will help to make sure every pods comes up in clean state.

Something similar done in recert project

https://github.com/openshift-kni/lifecycle-agent/blob/fd1cf27502b9c3f136fa1d161bcbd7ecf7c19da4/lca-cli/ops/ops.go#L186-L221

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from praveenkumar. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/crc-org/snc/blob/release-4.16/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

anjannath commented 3 months ago

/retest

openshift-ci[bot] commented 3 months ago

@praveenkumar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-snc	92a9481b90b9f99c71043f8dbf2a5560c4e7cc2b	link	true	`/test e2e-snc`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

praveenkumar commented 2 months ago

/close

959 surpass it.

openshift-ci[bot] commented 2 months ago

@praveenkumar: Closed this PR.

In response to [this](https://github.com/crc-org/snc/pull/936#issuecomment-2358574000): >/close > >#959 surpass it. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.