search

crc-org / snc

Single Node Cluster creation scripts for OpenShift 4.x as used by CodeReady Containers
https://crc.dev
Apache License 2.0
103 stars 50 forks source link

disable monitor tests #945

Closed redbeam closed 3 months ago

redbeam commented 3 months ago

944

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign praveenkumar for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/crc-org/snc/blob/release-4.16/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
praveenkumar commented 3 months ago

CI is still not green, does that mean, it still have something missing?

praveenkumar commented 3 months ago

we have a green CI run 👍🏼

praveenkumar commented 3 months ago

In the commit logs let's put more details around why we are disabling those monitor logs.

praveenkumar commented 3 months ago

/cherry-pick release-4.16

openshift-cherrypick-robot commented 3 months ago

@praveenkumar: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you.

In response to [this](https://github.com/crc-org/snc/pull/945#issuecomment-2264457978): >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-cherrypick-robot commented 3 months ago

@praveenkumar: base branch (release-4.16) needs to differ from target branch (release-4.16)

In response to [this](https://github.com/crc-org/snc/pull/945#issuecomment-2264457978): >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
gbraad commented 3 months ago

Is this because we disable Monitoring during deployment? Note: I am asking, as this might indicate 'dependencies' are in place for conformance.

praveenkumar commented 3 months ago

/cherry-pick release-4.17 /cherry-pick master

openshift-cherrypick-robot commented 3 months ago

@praveenkumar: new pull request created: #946

In response to [this](https://github.com/crc-org/snc/pull/945#issuecomment-2268266963): >/cherry-pick release-4.17 >/cherry-pick master Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
praveenkumar commented 3 months ago

/cherry-pick master

openshift-cherrypick-robot commented 3 months ago

@praveenkumar: new pull request created: #947

In response to [this](https://github.com/crc-org/snc/pull/945#issuecomment-2268275298): >/cherry-pick master Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.