search

crc-org / snc

Single Node Cluster creation scripts for OpenShift 4.x as used by CodeReady Containers
https://crc.dev
Apache License 2.0
103 stars 50 forks source link

ci.sh: moved test artifacts folder to crc-tmp-install-data #957

Closed redbeam closed 2 months ago

redbeam commented 2 months ago

Currently the artifacts generated by openshift-tests are lost when the pipeline finishes, with this change we move it inside the crc-tmp-install-data folder so that it gets uploaded to GCS.

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign praveenkumar for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/crc-org/snc/blob/release-4.16/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 months ago

@redbeam: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-microshift f832dca9696b7d543a4fb5c8d3ce053a09e150c3 link true /test e2e-microshift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
praveenkumar commented 2 months ago

It is now available https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/crc-org_snc/957/pull-ci-crc-org-snc-release-4.16-e2e-snc/1834158412548542464/artifacts/e2e-snc/gather-snc/artifacts/crc-tmp-install-data/ here

praveenkumar commented 2 months ago

/cherry-pick release-4.17 /cherry-pick master

openshift-cherrypick-robot commented 2 months ago

@praveenkumar: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you.

In response to [this](https://github.com/crc-org/snc/pull/957#issuecomment-2352038339): >/cherry-pick release-4.17 >/cherry-pick master Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-cherrypick-robot commented 2 months ago

@praveenkumar: #957 failed to apply on top of branch "release-4.17":

Applying: ci.sh: moved test artifacts folder to crc-tmp-install-data
Using index info to reconstruct a base tree...
M   ci.sh
Falling back to patching base and 3-way merge...
Auto-merging ci.sh
CONFLICT (content): Merge conflict in ci.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 ci.sh: moved test artifacts folder to crc-tmp-install-data
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/crc-org/snc/pull/957#issuecomment-2352038339): >/cherry-pick release-4.17 >/cherry-pick master Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-cherrypick-robot commented 2 months ago

@praveenkumar: #957 failed to apply on top of branch "master":

Applying: ci.sh: moved test artifacts folder to crc-tmp-install-data
Using index info to reconstruct a base tree...
M   ci.sh
Falling back to patching base and 3-way merge...
Auto-merging ci.sh
CONFLICT (content): Merge conflict in ci.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 ci.sh: moved test artifacts folder to crc-tmp-install-data
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/crc-org/snc/pull/957#issuecomment-2352038339): >/cherry-pick release-4.17 >/cherry-pick master Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.