search

crc-org / snc

Single Node Cluster creation scripts for OpenShift 4.x as used by CodeReady Containers
https://crc.dev
Apache License 2.0
103 stars 50 forks source link

ci: update go version from 1.21 to 1.22 #962

Closed praveenkumar closed 1 month ago

praveenkumar commented 1 month ago

crc moved to use go-1.22 but here it is built using 1.21 and result to an error.

praveenkumar commented 1 month ago

/cherry-pick release-4.18 /cherry-pick release-4.17 /cherry-pick release-4.16

openshift-cherrypick-robot commented 1 month ago

@praveenkumar: once the present PR merges, I will cherry-pick it on top of release-4.18 in a new PR and assign it to you.

In response to [this](https://github.com/crc-org/snc/pull/962#issuecomment-2370565407): >/cherry-pick release-4.18 >/cherry-pick release-4.17 >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
praveenkumar commented 1 month ago

/cherry-pick release-4.17

openshift-cherrypick-robot commented 1 month ago

@praveenkumar: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you.

In response to [this](https://github.com/crc-org/snc/pull/962#issuecomment-2370568971): >/cherry-pick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
praveenkumar commented 1 month ago

/cherry-pick release-4.16

openshift-cherrypick-robot commented 1 month ago

@praveenkumar: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you.

In response to [this](https://github.com/crc-org/snc/pull/962#issuecomment-2370569366): >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/crc-org/snc/blob/master/OWNERS)~~ [cfergeau] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-cherrypick-robot commented 1 month ago

@praveenkumar: new pull request created: #963

In response to [this](https://github.com/crc-org/snc/pull/962#issuecomment-2370565407): >/cherry-pick release-4.18 >/cherry-pick release-4.17 >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-cherrypick-robot commented 1 month ago

@praveenkumar: #962 failed to apply on top of branch "release-4.17":

Applying: ci: update go version from 1.21 to 1.22
Using index info to reconstruct a base tree...
M   ci_microshift.sh
Falling back to patching base and 3-way merge...
Auto-merging ci_microshift.sh
CONFLICT (content): Merge conflict in ci_microshift.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 ci: update go version from 1.21 to 1.22
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/crc-org/snc/pull/962#issuecomment-2370568971): >/cherry-pick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-cherrypick-robot commented 1 month ago

@praveenkumar: #962 failed to apply on top of branch "release-4.16":

Applying: ci: update go version from 1.21 to 1.22
Using index info to reconstruct a base tree...
M   ci.sh
M   ci_microshift.sh
Falling back to patching base and 3-way merge...
Auto-merging ci_microshift.sh
CONFLICT (content): Merge conflict in ci_microshift.sh
Auto-merging ci.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 ci: update go version from 1.21 to 1.22
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/crc-org/snc/pull/962#issuecomment-2370569366): >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.