search

crc-org / tray-macos

Small tray app for crc to perform common cluster operations
Apache License 2.0
5 stars 5 forks source link

Rearrange config options in the preferences window #52

Closed anjannath closed 3 years ago

anjannath commented 3 years ago

There are some options in the preferences window which fits better in the second tab (Advanced tab will be added), this issue is to list out what config option goes where and also which ones to keep in the UI.

Current Preferences window

gbraad commented 3 years ago

Consider to approach the design as a slab that is landscape, rather than portrait too

guillaumerose commented 3 years ago

Bundle text field can be removed.

gbraad commented 3 years ago

decrease the size for the memory and disksize fields a little, so the CPU can be identical? or at least group them clearly.

the size of the cpu COULD be slightly made to look biger is you add [no]{+]{-} buttons around it to increase and decrease the amount of CPU.... in that case we might not need to modify the size of the other fields...

... but the pull-secret in the middle of two distinctly VM related settings is not a good one... move it down or all the way up.

anjannath commented 3 years ago

It was also suggested to move the proxy stuff to the "Advanced" tab? I think it makes sense to do that as i don't think a lot of users need that, WDYT?

anjannath commented 3 years ago

Screenshot of the new design draft /cc @code-ready/crc-devel

Needs a few refinements still..

Screenshot 2021-01-29 at 11 38 11 AM

gbraad commented 3 years ago

better, but several spelling mistakes. Also, the spacing between the descriptuion and the property is not same for all; disksize for instance is spaced further away than memory and cpu... actually, looks like the top two are wrong. perhaps tooltip??? it makes it look cluttered now...

while overall MUCH cleaner.

gbraad commented 3 years ago

also, it is probably better to say the same as the property; "Consent about reporting telemetry"... better aks Kevin?

gbraad commented 3 years ago

BTW, Apply should be lower to the bottom of the window. It now feels related to Nameserver only. Note: if VSOCK is used, can we gray out the Nameserver value? it is not used in that case...

anjannath commented 3 years ago

also, it is probably better to say the same as the property; "Consent about reporting telemetry"... better aks Kevin?

@robin-owen Hi, can you please take a look at this, please suggest if any other sentences needs to be changed/improved (like the info for the pull-secret..)

gbraad commented 3 years ago

Note: Already pointed about the 'Redhat' mistake.

guillaumerose commented 3 years ago

vsock network mode toggle require to run crc setup. It's not possible to do it from the UI, so I guess, it's better to drop this option. Hopefully, this will be the default behavior soon!

anjannath commented 3 years ago

This is how it looks now https://github.com/code-ready/tray-macos/pull/50#issue-531715598

anjannath commented 3 years ago

Done in #50