search

crc-org / tray-macos

Small tray app for crc to perform common cluster operations
Apache License 2.0
5 stars 5 forks source link

Foreground colors in About window don't work with light mode #57

Closed jsliacan closed 3 years ago

jsliacan commented 3 years ago

This is 11.2 (Big Sur). Only logo is problematic, text OK.

Screenshot 2021-02-09 at 12 48 01 Screenshot 2021-02-09 at 12 52 43
anjannath commented 3 years ago

Looks like templated images are not working as expected for big sur, The image is correctly adjusted in light mode for catalina 10.15.7, have to test out all the other images also if they are working as expected.

Screenshot from catalina

Screenshot 2021-02-11 at 11 51 43 AM

anjannath commented 3 years ago

@jsliacan Still haven't updated to big sur, but i updated Xcode and it now has the big sur sdks, which i think should fix this issue, can you please try out this build (https://54-241065687-gh.circle-artifacts.com/0/crc-tray-macos.tar.gz) and check if the color issue is fixed now.

jsliacan commented 3 years ago

Sorry, still seems the same with Light theme on OS level.

Screenshot 2021-02-24 at 12 22 54
cfergeau commented 3 years ago

Same issue with 10.14

guillaumerose commented 3 years ago

Fixed by https://github.com/code-ready/tray-macos/commit/7e484035b911c3313507edcd1f053e3167fe5ed6