search

crc-org / tray-macos

Small tray app for crc to perform common cluster operations
Apache License 2.0
5 stars 5 forks source link

[Quit] should ask for confirmation and stop the VM #92

Open guillaumerose opened 3 years ago

guillaumerose commented 3 years ago

If the user quits the tray, I think we should ask him if he wants to shutdown the VM.

gbraad commented 3 years ago

Or informing the user the action does not stop the VM and inform the user "The cluster is running. Quitting the tray will not stop the OpenShift cluster. Are you sure you want to quit? [OK] {Cancel]"

The problem with the "Ask for confirmation to stop the VM" seems to indicate to always "quit" the tray... "Do you also want to stop the cluster? [OK] [Cancel]" -> Cancel would then ignore this question and still quit? There is ambiguity in this option.

/cc: @robin-owen suggestions?