Implement dialog with paste option for the pull-secret

crc-org / tray-windows

CodeReady Containers tray for windows

Apache License 2.0

2 stars 4 forks source link

Implement dialog with paste option for the pull-secret #99

Closed adrianriobo closed 3 years ago

adrianriobo commented 3 years ago

On tray for macos the behavior for the pull secret request has change. Now it asks for the content.

The windows tray still asks for the pull secret location.

So the pull secret is handle different on both trays, not only for the asking but for the storage. As the macos uses the keyring but the windows uses the config.

1 29 1-tray-windows-ps-file

gbraad commented 3 years ago

The inconsistency also comes from the page where the pull secret is obtained:

From a documentation POV it would be best to use a single method. /cc: @robin-owen We will allow for the paste option as this leaves no traces behind.

gbraad commented 3 years ago

The dialog used on macOS is as follows: