search

crc-org / vfkit

Apache License 2.0
119 stars 23 forks source link

Make e2e tests more robust #100

Closed cfergeau closed 6 months ago

cfergeau commented 6 months ago

Initial goal of this PR was to add a NVME test. However, it initially failed and this was quite hard to debug. This PR reworks the code in test/ to make unexpected failures easier to catch.

praveenkumar commented 6 months ago

/lgtm /approve

cfergeau commented 6 months ago

/approve

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau, praveenkumar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/crc-org/vfkit/blob/main/OWNERS)~~ [cfergeau] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment