Closed cfergeau closed 5 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from cfergeau. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
/lgtm
This PR adds 2 new types, which hopefully will help to make the code clearer. Some of the benefits are that Code-Hex/vz is now only imported in pkg/vf instead of being used directly in multiple places. The REST code is also simplified. This is preparation work for https://github.com/crc-org/vfkit/issues/48: the changes in the current PR will be useful for adding the path to the pty device in the REST API.
There should be no user-visible changes after this PR, just internal improvements.