search

crc-org / vfkit

Apache License 2.0
119 stars 23 forks source link

Add vf.VirtualMachine and vf.VirtualMachineConfiguration types #112

Closed cfergeau closed 5 months ago

cfergeau commented 5 months ago

This PR adds 2 new types, which hopefully will help to make the code clearer. Some of the benefits are that Code-Hex/vz is now only imported in pkg/vf instead of being used directly in multiple places. The REST code is also simplified. This is preparation work for https://github.com/crc-org/vfkit/issues/48: the changes in the current PR will be useful for adding the path to the pty device in the REST API.

There should be no user-visible changes after this PR, just internal improvements.

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from cfergeau. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/crc-org/vfkit/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
anjannath commented 5 months ago

/lgtm