search

crc-org / vfkit

Apache License 2.0
123 stars 24 forks source link

gh: Stop using macos11 runners #164

Closed cfergeau closed 2 weeks ago

cfergeau commented 2 months ago

This removes the macos11 usage from github actions, and starts using macos14 macos11 runners are deprecated or removed from github actions: https://github.blog/changelog/2024-05-20-actions-upcoming-changes-to-github-hosted-macos-runners/

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from cfergeau. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/crc-org/vfkit/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
praveenkumar commented 2 months ago

The test around macOS-14 is failing now.

cfergeau commented 2 months ago

The test around macOS-14 is failing now.

Yes it's being run on an arm64 node which can't do virt, so it's unfortunately an expected failure. I haven't found a way to force the run to be done on an amd64/macos14 node.

praveenkumar commented 2 months ago

The test around macOS-14 is failing now.

Yes it's being run on an arm64 node which can't do virt, so it's unfortunately an expected failure. I haven't found a way to force the run to be done on an amd64/macos14 node.

I don't think the runner for macos14 have intel one in the background only silicon available https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources which is on M1 (no virt support) . We either tweak the test case to run it on M1 or just don't add macOS-14 support for action.

cfergeau commented 3 weeks ago

The test around macOS-14 is failing now.

Yes it's being run on an arm64 node which can't do virt, so it's unfortunately an expected failure. I haven't found a way to force the run to be done on an amd64/macos14 node.

I don't think the runner for macos14 have intel one in the background only silicon available https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources which is on M1 (no virt support) . We either tweak the test case to run it on M1 or just don't add macOS-14 support for action.

I disabled the tests on macOS14. The tests in test/ require virtualization as they start a VM and check that the VM has the expected configuration. The other tests in pkg/ are unit tests and could be run without virt. Might be worth splitting them in make unit-tests and make e2e-tests so that we can run a few more tests on macOS 14

praveenkumar commented 2 weeks ago

Does this need rebase becuase lint is failing and using (1.60.2) ?

cfergeau commented 2 weeks ago

Does this need rebase becuase lint is failing and using (1.60.2) ?

lint is a mess at the moment, better to ignore it :-/

cfergeau commented 2 weeks ago

Does this need rebase becuase lint is failing and using (1.60.2) ?

lint is a mess at the moment, better to ignore it :-/

The lint issues are fixed in https://github.com/crc-org/vfkit/pull/185