search

crc-org / vfkit

Apache License 2.0
136 stars 26 forks source link

Infer version from `git describe` #17

Closed cfergeau closed 7 months ago

cfergeau commented 1 year ago

When making a release, the version in cmd/vfkit/root.go needs to be updated even if we push a tag with the same information. We could adapt https://github.com/git/git/blob/master/GIT-VERSION-GEN and use golang ldflags in order to automatically generate the correct version.

cfergeau commented 1 year ago

Anjan was suggesting to look into goreleaser instead, which is also an interesting option, as long as it lets us define the version in a single place. https://goreleaser.com/ci/actions/

cfergeau commented 7 months ago

This was fixed in https://github.com/crc-org/vfkit/pull/69