search

crc-org / vfkit

Apache License 2.0
122 stars 24 forks source link

The bundled gin server seems to be running in "debug" mode #175

Open afbjorklund opened 1 month ago

afbjorklund commented 1 month ago

Not sure what happened, but got the debugging output...

[GIN-debug] [WARNING] Creating an Engine instance with the Logger and Recovery middleware already attached.

[GIN-debug] [WARNING] Running in "debug" mode. Switch to "release" mode in production.
[GIN-debug] [WARNING] You trusted all proxies, this is NOT safe. We recommend you to set a value.
Please check https://github.com/gin-gonic/gin/blob/master/docs/doc.md#dont-trust-all-proxies for details.

There is a call to gin.SetMode(gin.ReleaseMode), though?

But no call to r.SetTrustedProxies(nil), as far as I can see.

cfergeau commented 3 weeks ago

Looks like I had a local commit fixing this, but never filed a PR for it :-/

cfergeau commented 3 weeks ago

This was actually already fixed in https://github.com/crc-org/vfkit/commit/20feaee0f3de20c87169a5568e08d0501a0823ce

afbjorklund commented 3 weeks ago

But never released ? Hmm, thought I grep'd

cfergeau commented 3 weeks ago

Yeah, it's not part of a release yet, I'll cut a new release in the coming days.