search

crc-org / vfkit

Apache License 2.0
123 stars 24 forks source link

Add readonly option for storage devices #179

Closed nirs closed 3 weeks ago

nirs commented 4 weeks ago

The virtio-blk, nvme, and usb-mass-storage devices can use now readonly option to create a read only device. This exposes the exiting StorageConfig.ReadOnly field.

Because this option is mostly useful to cdrom images, document the option only for usb-mass-storage.

openshift-ci[bot] commented 4 weeks ago

Hi @nirs. Thanks for your PR.

I'm waiting for a crc-org member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
cfergeau commented 3 weeks ago

/lgtm /approve

openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/crc-org/vfkit/blob/main/OWNERS)~~ [cfergeau] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
cfergeau commented 3 weeks ago

Thanks for the PR!