search

crc-org / vfkit

Apache License 2.0
123 stars 24 forks source link

doc: Fix recently reported issues #181

Closed cfergeau closed 2 weeks ago

cfergeau commented 3 weeks ago

This fixes minor (confusing) errors in the documentation and some lint errors.

openshift-ci[bot] commented 3 weeks ago

New changes are detected. LGTM label has been removed.

cfergeau commented 3 weeks ago

I dropped the SetTrustedProxies commit as it was alreadypresent in git master, and I added another commit to fix recent linting errors.

openshift-ci[bot] commented 3 weeks ago

@nirs: changing LGTM is restricted to collaborators

In response to [this](https://github.com/crc-org/vfkit/pull/181#pullrequestreview-2255065675): >Looks good Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude, nirs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/crc-org/vfkit/blob/main/OWNERS)~~ [baude] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
nirs commented 3 weeks ago

I think it will be better to split the commit handling possible integer overflow to another PR, and merge the easy changes now.

cfergeau commented 2 weeks ago

I think it will be better to split the commit handling possible integer overflow to another PR, and merge the easy changes now.

Yep, I was also getting to that conclusion, I initially thought the overflow changes would be a quick fix ;)

cfergeau commented 2 weeks ago

I think it will be better to split the commit handling possible integer overflow to another PR, and merge the easy changes now.

Yep, I was also getting to that conclusion, I initially thought the overflow changes would be a quick fix ;)

This is https://github.com/crc-org/vfkit/pull/185