search

crc-org / vfkit

Apache License 2.0
123 stars 24 forks source link

Fix linting issues #185

Closed cfergeau closed 2 weeks ago

cfergeau commented 2 weeks ago

This PR updates golangci-lint to the latest version, and fixes the various new issues reported by new version, most notably the int overflow ones. This also stops using the golangci-lint action to avoid automatic updates of golangci-lint, since these often need code changes which we might not be ready to make. The changes will be done instead through a go.mod update. The PRs will be created automatically by dependabot, but we can choose when to merge the change.

praveenkumar commented 2 weeks ago

looks like it need rebase

other than that /lgtm

cfergeau commented 2 weeks ago

looks like it need rebase

other than that /lgtm

Rebased, which cleared the /lgtm /o\

praveenkumar commented 2 weeks ago

Does this macOS-13 build failure is expected?

praveenkumar commented 2 weeks ago

Also I just merged https://github.com/crc-org/vfkit/pull/164 one so let's rebase on top of it?

cfergeau commented 2 weeks ago

Does this macOS-13 build failure is expected?

It's not expected, let's see if re-running it will succeed (rebase does not seem required) EDIT: rebase would get rid of the stale macos11 build, so I'll do this now :)

cfergeau commented 2 weeks ago

It's not expected, let's see if re-running it will succeed

All green this time!

praveenkumar commented 2 weeks ago

/lgtm /approve

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: praveenkumar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/crc-org/vfkit/blob/main/OWNERS)~~ [praveenkumar] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment