search

crc-org / vfkit

Apache License 2.0
123 stars 24 forks source link

custom json methods for virtual machine #43

Closed baude closed 1 year ago

baude commented 1 year ago

Add custom JSON methods for Marshal and Unmarshal so other projects can write a configuration file based on virtual machine. the key issue is the use of interfaces, for example devices, in virtual machine. When using JSON to marshal and unmarshal, we need to tag what kind of device it is so the process can tag and ultimately re-identify the proper device.

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from baude. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/crc-org/vfkit/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jakecorrenti commented 1 year ago

@cfergeau PTAL

jakecorrenti commented 1 year ago

@cfergeau friendly ping

baude commented 1 year ago

rebased and updated for virtioinput and virtiogpu

@jakecorrenti ptal

jakecorrenti commented 1 year ago

One small change, but lgtm otherwise

baude commented 1 year ago

fixed

cfergeau commented 1 year ago

Closing this in favour of https://github.com/crc-org/vfkit/pull/46 where I did some follow-up work.