search

crc-org / vfkit

Apache License 2.0
123 stars 24 forks source link

vf: Add toVz() methods for all virtio devices #49

Closed cfergeau closed 1 year ago

cfergeau commented 1 year ago

This follows the same model as for virtio-fs or virtio-blk devices so that it's possible to add multiple devices of the same type to the VM. The only exception is virtio-vsock which is documented by Apple as only being allowed once.

baude commented 1 year ago

LGTM

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/crc-org/vfkit/blob/main/OWNERS)~~ [baude] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment