search

crc-org / vfkit

Apache License 2.0
123 stars 24 forks source link

virtionet: Add gvproxy support #50

Closed cfergeau closed 1 year ago

cfergeau commented 1 year ago

This fixes --device virtio-net,unixSocketPath= which was non-functional until now, it was not using the correct socket type ("unix" instead of "unixgram"). This commit fixes this. Immediately after DialUnix("unixgram"), vfkit sends the magic string "VFKT" so that the other end knows where to send the data to (there is no Accept with unixgram sockets). There could be a better way but I'm not aware of it.

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/crc-org/vfkit/blob/main/OWNERS)~~ [baude] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment