No CGO for rest consumers/clients

crc-org / vfkit

Apache License 2.0

123 stars 24 forks source link

No CGO for rest consumers/clients #51

Closed baude closed 1 year ago

baude commented 1 year ago

Refactored portions of the rest code to not require CGO for rest consumers. Most of the refactored code was moved into pkg/rest/define to isolate it.

Also pruned an unused function and related unit test.

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gbraad Once this PR has been reviewed and has the lgtm label, please ask for approval from baude. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/crc-org/vfkit/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

cfergeau commented 1 year ago

An alternative would be to use interfaces to separate the code-hex/vz code from the rest code, I tried this in https://github.com/cfergeau/vfkit/commit/c39510306f8ead5268b8e8329d16dc201b249e76

baude commented 1 year ago

closing in favor of #52

openshift-merge-robot commented 1 year ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.