search

crc-org / vfkit

Apache License 2.0
123 stars 24 forks source link

rest: Isolate Code-Hex/vz code from the rest code #52

Closed cfergeau closed 1 year ago

cfergeau commented 1 year ago

Code-Hex/vz requires cgo/native builds, so it's preferrable to separate it from the client rest code. This PR achieves this by introducing interfaces to help move the mac-specific code to a separate package

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/crc-org/vfkit/blob/main/OWNERS)~~ [baude] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment